Adsk contrib - Add method to check inactive color space and an extra getRoleColorSpace method#1792
Merged
Conversation
Implements basic unit tests for those two methods. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Added the python bindings equivalents. Tweak C++ unit tests and added python unit tests. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Moving the new unit tests Adding extra tests for un-tested methods Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
remia
approved these changes
May 1, 2023
| OCIO_CHECK_EQUAL(std::string(config->getRoleName(-4)), ""); | ||
| OCIO_CHECK_EQUAL(std::string(config->getRoleColorSpace(-4)), ""); | ||
|
|
||
| // Test existing roles in cg-config-v1.0.0_aces-v1.3_ocio-v2.1. |
Collaborator
There was a problem hiding this comment.
[Minor] Remove the mention to cg config?
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
doug-walker
approved these changes
May 3, 2023
doug-walker
deleted the
adsk_contrib/add-method-to-check-inactive-colorspace
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following two methods:
isInactiveColorSpace- which tells the user if the specified color space is inactive or not.getRoleColorSpace- which tells the user the color space associated with the specified role name.